Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22634 closed defect (fixed)

throw the true cause, if parsing exception (regression 1.8.0)

Reported by: iwakeh Owned by: metrics-team
Priority: High Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Found and fixed by Karsten in this branch.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by iwakeh

Priority: MediumHigh
Status: newneeds_review

comment:2 Changed 3 years ago by iwakeh

Good catch!

Fix looks fine.

Please find a test for this fix here; two commits.

comment:3 in reply to:  2 Changed 3 years ago by karsten

Replying to iwakeh:

Good catch!

;)

Fix looks fine.

Please find a test for this fix here; two commits.

Great, thanks for the tests! Preparing a pre-release tarball now. Will post that here in 10 minutes.

comment:4 Changed 3 years ago by karsten

Please check whether this pre-release tarball looks good. If so, I'll put in on dist.tpo.

comment:5 Changed 3 years ago by iwakeh

Status: needs_reviewmerge_ready

All tests and checks pass, jars are signed, bytecode is reproducible from provided sources.

Looks ready for release.

comment:6 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for checking! Tarball is available here:

https://dist.torproject.org/descriptor/1.8.2/

Closing.

comment:8 Changed 3 years ago by karsten

Thank you!

Note: See TracTickets for help on using tickets.