Changes between Initial Version and Version 1 of Ticket #22636, comment 16


Ignore:
Timestamp:
Jul 17, 2017, 9:03:13 PM (5 months ago)
Author:
isis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22636, comment 16

    initial v1  
    1515> This is probably a good idea, as it tests more. The output might be a bit tricky to get, because the way it is configured right now, if some step fails, the whole CI build will fail fast.  So e.g. if compilation failed, don't waste more time testing.  Also if `make check-spaces` fails, your commit needs to be fixed up anyway, so again don't bother wasting time testing.  Whereas if we run `make check` it does all this in one go, and if it fails some step, it only reports that at the end of everything. Also, all the output that we'd need in order to see what failed gets shoved into a file (but possibly I can get that output with a `after-script` stanza?).
    1616 
    17 This is also done in [https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636&id=63928a0b1294324249c69c8165e13c808e11a335 commit] `63928a0b1294324249c69c8165e13c808e11a335`.
     17This is also done in [https://gitweb.torproject.org/user/isis/tor.git/commit/?h=bug22636&id=63928a0b1294324249c69c8165e13c808e11a335 commit] `63928a0b1294324249c69c8165e13c808e11a335`.
     18
     19(Note that the build is failing right now, but that's only because it doesn't include the fix for #22830 yet.)
    1820 
    1921> > Commenting the `.travis.yml` with brief explanations of these choices might be a good idea.  Also, squashing the commits somewhat would be good.  Some of the commit messages, like the ones involving Rust config choices, might work better as comments in `.travis.yml`.