Opened 2 years ago

Closed 2 years ago

#22669 closed defect (fixed)

When sending cached_dir_t objects compressed with zlib, do not claim zstd compression.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #22502 Points:
Reviewer: Sponsor: Sponsor4

Description (last modified by nickm)

Right now our code in handle_status_vote sends cached_dir_t objects in their deflated variant when compression is negotiated... but it claims to have compressed them with zstd when both sides support that.

This has been a bit of a heisenbug, since it only happens when we're downloading votes, which doesn't happen with the usual timing on chutney.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 2 years ago by nickm

Description: modified (diff)

comment:3 Changed 2 years ago by nickm

My bug22502_redux_031 has a fix for this in 782eb02b79363b

comment:4 Changed 2 years ago by nickm

Status: acceptedneeds_review

comment:5 Changed 2 years ago by nickm

Sponsor: Sponsor4

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed


Note: See TracTickets for help on using tickets.