Opened 3 years ago

Closed 3 years ago

#22672 closed defect (fixed)

Defensive programming: ensure no infinite COMPRESS_OK loops

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: Sponsor:


There's a possible failure mode if we've screwed up in our compression backends: we might say "COMPRESS_OK" over and over, while not making any progress. The changes I'm suggesting in #22629 turn this possible bug into a possible infinite loop.

I don't think this failure mode actually exists today, but let's prevent it anyway, by treating a COMPRESS_OK that makes no progress as if it were an error, and a BUG.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by nickm

Actual Points: .1
Points: .1
Status: newneeds_review

Fix in bug22672_031

comment:2 Changed 3 years ago by catalyst

Status: needs_reviewmerge_ready

Looks good to me.

comment:3 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed


Note: See TracTickets for help on using tickets.