Opened 3 months ago

Closed 3 months ago

#22683 closed enhancement (fixed)

adapt metrics-web to metrics-lib 2.0.0/1.9.0 changes

Reported by: iwakeh Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by iwakeh

Status: newneeds_information

Please set to review, if the branch progressed far enough.

comment:2 Changed 3 months ago by karsten

Status: needs_informationneeds_review

Please review my branch task-22683 which is an improved version of the branch above.

comment:3 Changed 3 months ago by karsten

Please also find another small fixup commit on top of my branch above.

comment:4 Changed 3 months ago by iwakeh

Status: needs_reviewmerge_ready

Code looks ok, compiles with descriptor-1.9.0 and metrics-lib-2.0.0

Merge ready.

Reminder: Before deployment it should be verified that results are the same as before on a reasonable test-set of descriptors.

Maybe, add a pre-deploy-testing ticket for this purpose?

comment:5 Changed 3 months ago by karsten

Resolution: implemented
Status: merge_readyclosed

Merged to master. I already ran quite a few tests yesterday, so I'm optimistic that a) nothing will break or b) I'll be able to notice and fix anything that breaks. :) Closing. Thanks!

comment:6 Changed 3 months ago by karsten

Resolution: implemented
Status: closedreopened

Re-opening, because I found a bug. Please review this commit in my task-22683-2 branch. Thanks!

comment:7 Changed 3 months ago by karsten

Status: reopenedneeds_review

comment:8 Changed 3 months ago by iwakeh

Status: needs_reviewmerge_ready

Mean bug, indeed!
So far, merge ready.

(There should be some code improvement in the near future. I'll add this to the list again.)

comment:9 Changed 3 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Merged to master. Re-closing. Thanks!

Note: See TracTickets for help on using tickets.