Opened 3 years ago

Last modified 3 years ago

#22723 new defect

Avoid double-quoting esc_for_log output

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: easy log annoyance tor-relay tor-client
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:


In #22368, arma posted a log where we double-quote relay nicknames.

[warn] There is a router named """" in my declared family, but that isn't a legal nickname. Skipping it.

Let's stop double-quoting esc_for_log output across the codebase.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by nickm

Keywords: annoyance added

Here's an easy way to find some of these these. Run this command:

git grep -A4 '\\"%s\\"'

It will give you the next 4 lines after every place where we have the string \"%s\" in the code. Then search that output for use of "escaped" or "esc_for_log".

comment:2 Changed 3 years ago by nickm

Keywords: tor-relay tor-client added
Note: See TracTickets for help on using tickets.