Opened 4 months ago

Closed 4 months ago

#22726 closed defect (fixed)

prop224: Ignore unparseable v3 introduction points

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, review-group-19
Cc: Actual Points:
Parent ID: #21888 Points:
Reviewer: nickm, asn Sponsor: SponsorR-must

Description

For forward compat., we should just ignore unknown introduction points fields in a prop224 descriptor.

This is groundwork for prop224.

Child Tickets

Change History (7)

comment:1 Changed 4 months ago by dgoulet

Status: newneeds_review

Branch ticket22726_032_01.

comment:2 Changed 4 months ago by nickm

Keywords: review-group-19 added

comment:3 Changed 4 months ago by asn

Reviewer: nickmnickm, asn

comment:4 Changed 4 months ago by asn

Status: needs_reviewneeds_revision

Code LGTM.

Only nitpick: decode_intro_points() is STATIC but not unittested.

Marking needs_revision just for this.

comment:5 Changed 4 months ago by dgoulet

Status: needs_revisionmerge_ready

Fixed in ticket22726_032_02. Going in merge_ready

comment:6 Changed 4 months ago by nickm

lgtm; merged to master. Please make a corresponding spec change?

comment:7 Changed 4 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

It is in the spec already. We just failed to put it in the code properly:

   To remain compatible with future revisions to the descriptor format,
   clients should ignore unrecognized lines in the descriptor.
   Other encryption and authentication key formats are allowed; clients
   should ignore ones they do not recognize.

Thanks!

Note: See TracTickets for help on using tickets.