#22727 closed enhancement (implemented)

prop224: Add functions to check for HS v3 support

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, review-group-19
Cc: Actual Points:
Parent ID: #21888 Points:
Reviewer: nickm, asn Sponsor: SponsorR-must

Description

This is groundwork for prop224.

It simply adds two functions for to nodelist.h that checks for v3 hsdir support (HSDir 3 protover) and ed25519 intro point (HSIntro 4 protover).

Child Tickets

Change History (12)

comment:1 Changed 21 months ago by dgoulet

Status: newneeds_review

Branch: ticket22727_032_01

comment:2 Changed 21 months ago by nickm

Keywords: review-group-19 added

comment:3 Changed 21 months ago by asn

Reviewer: nickmnickm, asn

comment:4 Changed 21 months ago by dgoulet

Status: needs_reviewneeds_revision

Some fix is needed to handle empty protocol_list. Upcoming branch in a jiffy. asn did ACK the branch on IRC once that is fixed.

comment:5 Changed 21 months ago by dgoulet

Status: needs_revisionmerge_ready

Merge ready branch in ticket22727_032_02.

comment:6 Changed 21 months ago by asn

Status: merge_readyneeds_revision

After Roger's comment from yesterday, let's add some defines for those protover magic values like '2' which are super counter-intuitive since they say '2' but they actually mean HSv3.

Will make fixup in a sec.

comment:7 Changed 21 months ago by asn

Status: needs_revisionmerge_ready

Please check my branch ticket22727_032_02 which contains an extra commit that makes the protover magic numbers a bit more readable. Thanks!

comment:8 Changed 21 months ago by dgoulet

How about we put those in protover.h? Would be a good thing to have all those values in one place and related to that protocol version subsystem instead of scattered around in different C files?

comment:9 Changed 21 months ago by asn

Hey david, I force pushed another ticket22727_032_02 with the defines inside protover.h.
How do you like this one?

comment:10 Changed 21 months ago by dgoulet

ack!

comment:11 Changed 21 months ago by asn

Just summarizing here by saying that the branch to review here is ticket22727_032_02 in my repo.

comment:12 Changed 21 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

looks fine; merging!

Note: See TracTickets for help on using tickets.