Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#22742 closed defect (fixed)

torspec should say when tor's event buffer limit was removed

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec
Cc: Actual Points: .1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

There is no limit now, it was removed in:

5.2. Don't let the buffer get too big.

  If you ask for lots of events, and 16MB of them queue up on the buffer,
  the Tor process will close the socket.

This happened in #16480 or maybe some time before it.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by nickm

Actual Points: .1
Resolution: fixed
Status: newclosed

Whoa. This warning dates back to 2004, when MAX_BUF_SIZE was a thing that buffers.c enforced. But we removed MAX_BUF_SIZE back in 2007 when we replaced the buffer implementation.

Fixed in b38e7ef011ffca4967e53bc461cc8af98ff78917

comment:2 Changed 4 months ago by teor

Keywords: tor-spec added

Consistently use tor-spec across all tickets (add tor-spec).

comment:3 Changed 4 months ago by teor

Keywords: torspec removed

Consistently use tor-spec across all tickets (remove torspec).

Note: See TracTickets for help on using tickets.