Opened 8 months ago

Closed 8 months ago

#22754 closed defect (fixed)

Reference checker should only read relay descriptors

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone: CollecTor 1.2.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I just noticed that ReferenceChecker reads bridge descriptors in my local test instance. Looks like we changed paths in this commit to include all recent descriptors, not just recent relay descriptors:

-    new ReferenceChecker(new File("recent/relay-descriptors"),
-        new File("stats/references"),
-        new File("stats/references-history")).check();
+    new ReferenceChecker(
+        recentPath.toFile(),
+        new File(config.getPath(Key.StatsPath).toFile(), "references"),
+        new File(config.getPath(Key.StatsPath).toFile(), "references-history")).check();

We should probably change that back to avoid reading descriptors we don't care about anyway.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by karsten

Milestone: CollecTor 1.2.0

This seems trivial enough to include it in the next release.

comment:2 Changed 8 months ago by karsten

Status: newneeds_review

comment:3 Changed 8 months ago by iwakeh

Status: needs_reviewmerge_ready

Makes sense; all tests and checks pass.
Ready for release.

comment:4 Changed 8 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for checking! Merged to master. Closing.

Note: See TracTickets for help on using tickets.