Opened 3 years ago

Last modified 3 years ago

#22760 new defect

Fix extra-info flags on fallbacks

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor:
Severity: Minor Keywords: fallback, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description (last modified by teor)

See the first comment for details.

Child Tickets

Change History (11)

comment:1 Changed 3 years ago by teor

There are some more bugs we should fix here:

  • fallback_dir_server_new() shouldn't mark all fallbacks with ALL_DIRINFO
  • SKIP_MISSING_TRUSTED_EXTRAINFO() / router_supports_extrainfo() should believe the node, and only use router_digest_is_trusted_dir_type() if the node is NULL. (This allows descriptors to override hard-coded settings.)

comment:2 Changed 3 years ago by teor

We will backport the new fallback list format to 0.2.8 and later, so we might need two versions of this code:

  • a backport version that ignores the extrainfo tag
  • a master version that parses the tag, uses it to set the extrainfo type via fallback_dir_server_new(), and correctly handles the extrainfo type when bootstrapping.

comment:3 Changed 3 years ago by teor

Owner: set to teor
Status: newassigned

comment:4 Changed 3 years ago by teor

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

I'm not going to get time to do these in 0.3.2.
Moving them to 0.3.3.

comment:5 Changed 3 years ago by teor

Description: modified (diff)
Keywords: fallback added
Parent ID: #22759
Summary: Parse or ignore falback extra-info markersFix extra-info flags on fallbacks
Type: enhancementdefect
Version: Tor:

Since we never download extra-infos until we have the consensus, we should just fix the bugs listed in the first comment, and call this done.

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final
Owner: teor deleted
Parent ID: #24786

We could do this as part of the next fallback rebuild if we wanted to.
I won't get time to do it in 0.3.3.

comment:7 Changed 3 years ago by teor

Priority: MediumLow
Severity: NormalMinor

comment:8 Changed 3 years ago by nickm

Keywords: 034-triage-20180328 added

comment:9 Changed 3 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:10 Changed 3 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:11 Changed 3 years ago by teor

Parent ID: #24786
Status: assignednew

This ticket is not part of the minimal fallback rebuild.

Note: See TracTickets for help on using tickets.