Fix extra-info flags on fallbacks

See the first comment for details.

changed milestone to %Tor: unspecified

added 034-removed-20180328 034-triage-20180328 component::core tor/tor fallback milestone::Tor: unspecified points::0.5 priority::low severity::minor status::new type::defect version::tor 0.2.8.1-alpha labels

There are some more bugs we should fix here:

• fallback_dir_server_new() shouldn't mark all fallbacks with ALL_DIRINFO
• SKIP_MISSING_TRUSTED_EXTRAINFO() / router_supports_extrainfo() should believe the node, and only use router_digest_is_trusted_dir_type() if the node is NULL. (This allows descriptors to override hard-coded settings.)

We will backport the new fallback list format to 0.2.8 and later, so we might need two versions of this code:

• a backport version that ignores the extrainfo tag
• a master version that parses the tag, uses it to set the extrainfo type via fallback_dir_server_new(), and correctly handles the extrainfo type when bootstrapping.

Trac:
Owner: N/A to teor
Status: new to assigned

I'm not going to get time to do these in 0.3.2. Moving them to 0.3.3.

Trac:
Milestone: Tor: 0.3.2.x-final to Tor: 0.3.3.x-final

Since we never download extra-infos until we have the consensus, we should just fix the bugs listed in the first comment, and call this done.

Trac:
Type: enhancement to defect
Version: N/A to Tor: 0.2.8.1-alpha
Summary: Parse or ignore falback extra-info markers to Fix extra-info flags on fallbacks
Parent: #22759 (moved) to N/A
Description: See #22759 (moved) for details.

to

See the first comment for details.
Keywords: N/A deleted, fallback added

We could do this as part of the next fallback rebuild if we wanted to. I won't get time to do it in 0.3.3.

Trac:
Parent: N/A to #24786 (moved)
Owner: teor to N/A
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.4.x-final

Trac:
Priority: Medium to Low
Severity: Normal to Minor

Trac:
Keywords: N/A deleted, 034-triage-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

Trac:
Keywords: N/A deleted, 034-removed-20180328 added

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: unspecified

This ticket is not part of the minimal fallback rebuild.

Trac:
Parent: #24786 (moved) to N/A
Status: assigned to new

changed time estimate to 4h

moved to tpo/core/tor#22760 (closed)