Opened 4 months ago

Last modified 5 weeks ago

#22760 assigned enhancement

Parse or ignore falback extra-info markers

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #22759 Points: 0.5
Reviewer: Sponsor:


See #22759 for details.

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by teor

There are some more bugs we should fix here:

  • fallback_dir_server_new() shouldn't mark all fallbacks with ALL_DIRINFO
  • SKIP_MISSING_TRUSTED_EXTRAINFO() / router_supports_extrainfo() should believe the node, and only use router_digest_is_trusted_dir_type() if the node is NULL. (This allows descriptors to override hard-coded settings.)

comment:2 Changed 4 months ago by teor

We will backport the new fallback list format to 0.2.8 and later, so we might need two versions of this code:

  • a backport version that ignores the extrainfo tag
  • a master version that parses the tag, uses it to set the extrainfo type via fallback_dir_server_new(), and correctly handles the extrainfo type when bootstrapping.

comment:3 Changed 3 months ago by teor

Owner: set to teor
Status: newassigned

comment:4 Changed 5 weeks ago by teor

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

I'm not going to get time to do these in 0.3.2.
Moving them to 0.3.3.

Note: See TracTickets for help on using tickets.