Opened 4 months ago

Closed 5 weeks ago

#22797 closed defect (fixed)

macOS should use ULIMIT_BUFFER for open files

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: macOS, file-limits, 029-backport, 030-backport
Cc: Actual Points:
Parent ID: #21074 Points: 0.2
Reviewer: ahf Sponsor:

Description

The workaround to use OPEN_MAX for open files doesn't subtract ULIMIT_BUFFER from the limit that's used.

This was introduced in tor-0.2.0.10-alpha.

Child Tickets

Change History (13)

comment:1 Changed 4 months ago by teor

Status: newneeds_review

Please see my branch bug22797-031 on github.

comment:2 Changed 4 months ago by ahf

Reviewer: ahf

comment:3 Changed 4 months ago by ahf

Status: needs_reviewmerge_ready

Patch looks good to me.

comment:4 Changed 4 months ago by nickm

Keywords: 029-backport 030-backport added

comment:5 Changed 4 months ago by nickm

Keywords: review-group-20 added

Creating review-group-20

comment:6 Changed 4 months ago by nickm

Owner: set to teor
Status: merge_readyassigned

setting owner

comment:7 Changed 4 months ago by nickm

Status: assignedneeds_review

comment:8 Changed 4 months ago by nickm

Status: needs_reviewmerge_ready

comment:9 Changed 4 months ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: 0.3.0.x-final

I've rebased this as teor-bug22797-025 in case we decide to backport further, and merged it to 0.3.1 and forwards. Already marked for possible 0.2.9 or 0.3.0 backport.

comment:10 Changed 4 months ago by nickm

Keywords: review-group-20 removed

comment:11 Changed 4 months ago by nickm

clang gave me a mixed sign comparison warning here: I applied 9383fa3851a47e4db83bccdb923760e059ac7941 to fix it.

comment:12 Changed 4 months ago by teor

That warning only happens on non-macOS, which explains how I missed it.
I also check this code compiled on macOS i386, just to make sure.

comment:13 Changed 5 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Backporting to 0.2.9 and forward; marking parent closed.

Note: See TracTickets for help on using tickets.