Opened 6 weeks ago

Closed 5 weeks ago

#22803 closed defect (fixed)

Memory leak in link-handshake/certs_ok_ed25519

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: 030-backport 031-backport tor-tests memory-leak
Cc: Actual Points: .1
Parent ID: Points:
Reviewer: asn Sponsor:

Description

=================================================================
==24816==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 160 byte(s) in 1 object(s) allocated from:

#0 0x7fe721373e60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x5582ccbf96ea in tor_malloc_ src/common/util.c:150
#2 0x5582ccbf9791 in tor_malloc_zero_ src/common/util.c:178
#3 0x5582ccb7d8ae in tor_x509_cert_newreal src/common/tortls.c:677
#4 0x5582cc61f504 in test_link_handshake_certs_ok src/test/test_link_handshake.c:232
#5 0x5582cc783a78 in testcase_run_bare_ src/ext/tinytest.c:106
#6 0x5582cc783f76 in testcase_run_forked_ src/ext/tinytest.c:190
#7 0x5582cc783f76 in testcase_run_one src/ext/tinytest.c:248
#8 0x5582cc785465 in tinytest_main src/ext/tinytest.c:435
#9 0x5582cc3d7846 in main src/test/testing_common.c:319
#10 0x7fe71e6c4400 in
libc_start_main (/lib64/libc.so.6+0x20400)

Indirect leak of 3050 byte(s) in 58 object(s) allocated from:

#0 0x7fe721373e60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x7fe7204e03e7 in CRYPTO_malloc (/lib64/libcrypto.so.10+0x6e3e7)

Indirect leak of 579 byte(s) in 1 object(s) allocated from:

#0 0x7fe721373e60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x5582ccbf96ea in tor_malloc_ src/common/util.c:150
#2 0x5582ccb7d904 in tor_x509_cert_newreal src/common/tortls.c:687
#3 0x5582cc61f504 in test_link_handshake_certs_ok src/test/test_link_handshake.c:232
#4 0x5582cc783a78 in testcase_run_bare_ src/ext/tinytest.c:106
#5 0x5582cc783f76 in testcase_run_forked_ src/ext/tinytest.c:190
#6 0x5582cc783f76 in testcase_run_one src/ext/tinytest.c:248
#7 0x5582cc785465 in tinytest_main src/ext/tinytest.c:435
#8 0x5582cc3d7846 in main src/test/testing_common.c:319
#9 0x7fe71e6c4400 in
libc_start_main (/lib64/libc.so.6+0x20400)

Child Tickets

Change History (5)

comment:1 Changed 6 weeks ago by nickm

Keywords: 029-backport 030-backport 031-backport added; ???-backport removed
Owner: set to nickm
Status: newaccepted

comment:2 Changed 6 weeks ago by nickm

Actual Points: .1
Keywords: tor-tests memory-leak added; 029-backport removed
Severity: NormalMinor
Status: acceptedneeds_review

See branch bug22803_030, for backport to 0.3.0 and 0.3.1

comment:3 Changed 5 weeks ago by asn

Reviewer: asn

comment:4 Changed 5 weeks ago by asn

Status: needs_reviewmerge_ready

Looks good to me and seems to fix the leak!

comment:5 Changed 5 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Thanks! Merged to 0.3.0 and forward!

Note: See TracTickets for help on using tickets.