Opened 3 years ago

Closed 3 years ago

#22833 closed enhancement (implemented)

Either include or retain "fingerprint" line in bridge network statuses with @type bridge-network-status 1.2

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone: CollecTor 1.2.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


#22207 adds a new "fingerprint" line which we should keep in the sanitizing process, or add it for original statuses published prior to this patch. I'll attach a branch in a minute.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by karsten

Status: newneeds_review

Please review my branch task-22833.

comment:2 Changed 3 years ago by karsten

Milestone: CollecTor 1.2.0

We should include this patch in the next release, because #22207 is already merged into Tor, and as soon as there's a release and the bridge authority updates, we'll need this patch.

comment:3 Changed 3 years ago by iwakeh

Status: needs_reviewmerge_ready

Yep, CollecTor should be prepared. The tests and checks pass.

I'm wondering if there should also be tests for the old type bridge-network-status 1.1?

Other than that ready for release.

comment:4 Changed 3 years ago by karsten

Resolution: implemented
Status: merge_readyclosed

Thanks for looking! Cherry-picked and merged to master.

Regarding tests for 1.1, I don't think those are critically important. We don't have tests for 1.0 or other superseded descriptor type versions, either. And we won't produce version 1.1 anymore quite soon. I think these tests wouldn't help us much. But if you'd like to add more tests, I'll merge them.


Note: See TracTickets for help on using tickets.