about:tor page is not showing up in non-e10s mode after fix for #18913 landed

I investigated #22788 (moved) and while doing so realized that the about:tor page is not showing up when starting in non-e10s mode. Bisecting leads to the fix for #18913 (moved). This happens on a Linux box at least.

added TorBrowserTeam201707R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-torbutton type::defect labels

Kathy and I can sometimes reproduce this problem even when in e10s mode. But adding about:tor to the NoScript whitelist preference (capability.policy.maonoscript.sites) always fixes the problem for us (or moving the security slider level to low).

Georg, do those changes fix the problem for you?

Trac:
Status: new to needs_information

Yes. I guess adding about:tor to our whitelist as we did with a bunch of other about: pages solved this for me.

Trac:
Status: needs_information to assigned

gk: what do you think of the idea of whitelisting all about: pages? (assuming that is possible) Too risky, or a good idea?

Trac:
Status: assigned to needs_information

Replying to mcs:

gk: what do you think of the idea of whitelisting all about: pages? (assuming that is possible) Too risky, or a good idea?

I am a bit reluctant doing so. It makes me a bit nervous to say "whatever about: page gets registered/used allow it". Even if it is a bit annoying I'd like to move forward on a case-by-case basis.

Trac:
Status: needs_information to assigned

Replying to gk:

I am a bit reluctant doing so. It makes me a bit nervous to say "whatever about: page gets registered/used allow it". Even if it is a bit annoying I'd like to move forward on a case-by-case basis.

That's fine; I just thought I would ask. Here is a patch: https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug22884-01

Trac:
Keywords: TorBrowserTeam201707 deleted, TorBrowserTeam201707R added
Status: assigned to needs_review

Thanks. Merged to master with commit 355f03e18d7de4b9ca67d9e88ac6abce4c68d96b.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#22884 (closed)