Opened 5 months ago

Closed 5 months ago

#22884 closed defect (fixed)

about:tor page is not showing up in non-e10s mode after fix for #18913 landed

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201707R, tbb-torbutton
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I investigated #22788 and while doing so realized that the about:tor page is not showing up when starting in non-e10s mode. Bisecting leads to the fix for #18913. This happens on a Linux box at least.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by mcs

Status: newneeds_information

Kathy and I can sometimes reproduce this problem even when in e10s mode. But adding about:tor to the NoScript whitelist preference (capability.policy.maonoscript.sites) always fixes the problem for us (or moving the security slider level to low).

Georg, do those changes fix the problem for you?

comment:2 Changed 5 months ago by gk

Status: needs_informationassigned

Yes. I guess adding about:tor to our whitelist as we did with a bunch of other about: pages solved this for me.

comment:3 Changed 5 months ago by mcs

Status: assignedneeds_information

gk: what do you think of the idea of whitelisting all about: pages? (assuming that is possible) Too risky, or a good idea?

comment:4 in reply to:  3 ; Changed 5 months ago by gk

Status: needs_informationassigned

Replying to mcs:

gk: what do you think of the idea of whitelisting all about: pages? (assuming that is possible) Too risky, or a good idea?

I am a bit reluctant doing so. It makes me a bit nervous to say "whatever about: page gets registered/used allow it". Even if it is a bit annoying I'd like to move forward on a case-by-case basis.

comment:5 in reply to:  4 Changed 5 months ago by mcs

Keywords: TorBrowserTeam201707R added; TorBrowserTeam201707 removed
Status: assignedneeds_review

Replying to gk:

I am a bit reluctant doing so. It makes me a bit nervous to say "whatever about: page gets registered/used allow it". Even if it is a bit annoying I'd like to move forward on a case-by-case basis.

That's fine; I just thought I would ask. Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug22884-01

comment:6 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Merged to master with commit 355f03e18d7de4b9ca67d9e88ac6abce4c68d96b.

Note: See TracTickets for help on using tickets.