Opened 8 months ago

Last modified 3 months ago

#22907 needs_review task

Investigate using cargo-vendor for offline dependencies

Reported by: isis Owned by: isis
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, rust-pilot, tor-build, 032-unreached
Cc: acrichton@…, chelseakomlo, manishearth@… Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor: SponsorZ

Description

People on the cargo team recommended we look into using https://github.com/alexcrichton/cargo-vendor to facilitate our offline builds. (See also #22830)

Child Tickets

Change History (11)

comment:1 Changed 7 months ago by Sebastian

We're already using that I thought?

comment:2 Changed 7 months ago by alexcrichton

Cc: acrichton@… added

comment:3 in reply to:  1 Changed 7 months ago by isis

Replying to Sebastian:

We're already using that I thought?


Perhaps you used it when you were setting up the RUST_DEPENDENCIES build stuff? That would make a lot more sense! (I had not heard of cargo vendor until yesterday, and our docs don't say anything about it.)

comment:4 Changed 7 months ago by chelseakomlo

Cc: chelseakomlo added

comment:5 Changed 7 months ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: 0.3.2.x-final

Defer these rust tickets to 0.3.2

comment:6 Changed 5 months ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

comment:7 Changed 4 months ago by manish.earth

Cc: manishearth@… added

comment:8 Changed 3 months ago by isis

Sebastian says he did use cargo-vendor to set up the offline builds, but it was in a separate repo (https://gitweb.torproject.org/user/sebastian/tor-rust-dependencies.git) which is also one of our submodules, and I think we forgot to document that or something. I'll test out how it's still working and write some notes on how to get going with it.

comment:9 Changed 3 months ago by isis

Owner: set to isis
Status: newaccepted

comment:10 Changed 3 months ago by isis

Status: acceptedneeds_review

Okay, there's some better documentation and some Travis CI builds for cargo in offline-mode in my bug22907 branch. Hopefully this satisfies some of what's needed for #22768?

comment:11 Changed 3 months ago by nickm

Looks okay; merged this to master. Please close or set to "new" again as appropriate?

Note: See TracTickets for help on using tickets.