Our Rust code is always built in debug mode

In src/rust/Cargo.toml:

[profile.release]
debug = true

This enables certain things, e.g. debug_assert!(false = true) will panic. It also does stuff like bounds checks for every access and integer overflow/underflow checks every time any number is used. These are great things to do, but they are usually done in debug builds which are used in testing, not in release. This will make our code literally hundreds of times slower, so we should probably remove this.

changed milestone to %Tor: 0.3.3.x-final

added component::core tor/tor milestone::Tor: 0.3.3.x-final points::.1 priority::medium resolution::invalid rust rust-pilot severity::normal sponsor::Z status::closed tor-build type::defect labels

https://doc.crates.io/manifest.html#the-profile-sections

debug = true is for generating debuginfo. asserts are something else, debug-assertions.

Trac:
Status: new to closed
Resolution: N/A to invalid

Reason this is invalid: We're matching Tor's C code behaviour here, which always includes debug symbols, even in releases.

Replying to Sebastian:

Reason this is invalid: We're matching Tor's C code behaviour here, which always includes debug symbols, even in releases.

That makes sense to try to match the C behaviour. Although, I think building Rust code in debug mode isn't really comparable to a C binary with debugging symbols… there's extra stuff going on there (like the over/under-flow checks), and it's not like we can just run strip on it to make it what it would've been without debugging enabled. It's more like building a C binary with UBSan and whatever other sanitisers enabled, which IIRC we don't do (--enable-expensive-hardening is off by default).

Trac:
Resolution: invalid to N/A
Status: closed to reopened

On http://doc.crates.io/guide.html:

"Compiling in debug mode is the default for development-- compilation time is shorter since the compiler doesn't do optimizations, but the code will run slower. Release mode takes longer to compile, but the code will run faster."

Trac:
Cc: N/A to chelseakomlo

Defer these rust tickets to 0.3.2

Trac:
Milestone: Tor: 0.3.1.x-final to Tor: 0.3.2.x-final

I should have been explicit earlier but this ticket really should be closed, it is invalid.

debug mode is [profile.debug], i.e. what happens when you leave out --release when invoking cargo.

debug = true is not "debug mode", it is to tell rustc to add DWARF2 debuginfo to the ELF binaries and is equivalent to -g flags to C compilers.

Whoops, that should have been [profile.dev] not [profile.debug], see the first link I posted. The rest of the comment is correct.

Trac:
Milestone: Tor: 0.3.2.x-final to Tor: 0.3.3.x-final

Replying to infinity0:

I should have been explicit earlier but this ticket really should be closed, it is invalid.

debug mode is [profile.debug], i.e. what happens when you leave out --release when invoking cargo.

debug = true is not "debug mode", it is to tell rustc to add DWARF2 debuginfo to the ELF binaries and is equivalent to -g flags to C compilers.

Ah, I'm sorry, I understand what you meant now. -g just means it's passing -C debuginfo=2. Closing as invalid.

Trac:
Status: reopened to closed
Resolution: N/A to invalid

closed

changed time estimate to 48m

moved to tpo/core/tor#22909 (closed)