Opened 5 weeks ago

Closed 5 weeks ago

#22916 closed defect (fixed)

Clang warnings when building with openssl and scrypt

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 027-backport 028-backport 029-backport 030-backport 031-backport
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: isis Sponsor: Sponsor3-can

Description

src/test/test_crypto_slow.c:161:23: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);
                      ^
src/test/test_crypto_slow.c:161:26: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);
                         ^
src/test/test_crypto_slow.c:181:23: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);
                      ^
src/test/test_crypto_slow.c:181:26: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);
                         ^
src/test/test_crypto_slow.c:204:23: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);
                      ^
src/test/test_crypto_slow.c:204:26: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);
                         ^
src/test/test_crypto_slow.c:228:23: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);
                      ^
src/test/test_crypto_slow.c:228:26: error: implicit conversion loses integer
      precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
      (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                   N, r, p, buf1, dk_len);

Child Tickets

Change History (5)

comment:1 Changed 5 weeks ago by nickm

Actual Points: .1
Status: newneeds_review

See branch bug22916_027. I suggest we backport no farther than 0.2.9

comment:2 Changed 5 weeks ago by isis

Reviewer: isis
Sponsor: Sponsor3-can

comment:3 Changed 5 weeks ago by isis

LGTM!

comment:4 Changed 5 weeks ago by isis

Status: needs_reviewmerge_ready

comment:5 Changed 5 weeks ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.2.9.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.2.9 and forward.

Note: See TracTickets for help on using tickets.