#22951 closed defect (fixed)

NETINFO cells are mandatory, but tor-spec says "may"

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec easy doc
Cc: Actual Points:
Parent ID: #18856 Points:
Reviewer: Sponsor:

Description

In this context, "may" is ambiguous: NETINFO is actually a mandatory requirement:

   cell (4.5).  As soon as it gets the CERTS cell, the initiator knows
   whether the responder is correctly authenticated.  At this point the
-  initiator may send a NETINFO cell if it does not wish to
+  initiator MUST send a NETINFO cell if it does not wish to
   authenticate, or a CERTS cell, an AUTHENTICATE cell (4.4), and a NETINFO
   cell if it does.  When this handshake is in use, the first cell must
   be VERSIONS, VPADDING or AUTHORIZE, and no other cell type is allowed to
   intervene besides those specified, except for PADDING and VPADDING cells.

https://gitweb.torproject.org/torspec.git/tree/tor-spec.txt#n482

Child Tickets

Change History (4)

comment:1 Changed 22 months ago by teor

Status: newneeds_revision

A disgnostic script that demonstrates this is available at:
https://github.com/teor2345/endosome/blob/master/client-or-22951.py

comment:2 Changed 21 months ago by nickm

Should this be needs_review?

comment:3 Changed 21 months ago by teor

Status: needs_revisionneeds_review

Oops

comment:4 Changed 21 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Fixed in fa2c8ae9f7f753. I put in MUSTs, and split the sentence into two. Thanks!

Note: See TracTickets for help on using tickets.