Opened 2 years ago

Closed 2 years ago

#22964 closed defect (fixed)

Clarify comment about all tor data being encrypted

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: comment
Cc: Actual Points:
Parent ID: #22961 Points:
Reviewer: Sponsor:

Description

This isn't quite accurate:

  /* Don't actually allow compression; it uses ram and time, but the data
   * we transmit is all encrypted anyway. */

The following "data" isn't encrypted:

  • cell headers
  • non-relay cell types

I suggest:

  /* Don't actually allow compression; it uses ram and time, but the
   * circuit data we transmit is encrypted anyway. */

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by teor

Owner: set to teor
Status: newassigned

comment:2 Changed 2 years ago by teor

Status: assignedneeds_review

comment:3 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

I did something similar in db1664e5932ae0435b23c2ca92e74f3a5c64c1f8, moving the comment, referencing the CRIME attack, and being less specific about what's encrypted, but more specific about why it matters in this context what's encrypted.

Note: See TracTickets for help on using tickets.