Opened 18 months ago

Closed 17 months ago

Last modified 17 months ago

#22989 closed defect (fixed)

TBB Size 1000x610 Mac

Reported by: Dbryrtfbcbhgf Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-fingerprinting-resolution, tbb-torbutton, TorBrowserTeam201708R, tbb-7.0-issues, tbb-regression
Cc: arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The browser size is 1000x610 on my Mac running 10.12.6 (16G29)
TBB 7.0.2 and TBB 7.5a2

Child Tickets

Attachments (4)

tor bug.png (457.7 KB) - added by Dbryrtfbcbhgf 18 months ago.
tor bug stable.png (445.7 KB) - added by Dbryrtfbcbhgf 18 months ago.
TBB bug.png (467.4 KB) - added by Dbryrtfbcbhgf 18 months ago.
firefox.png (354.5 KB) - added by Dbryrtfbcbhgf 18 months ago.

Download all attachments as: .zip

Change History (28)

Changed 18 months ago by Dbryrtfbcbhgf

Attachment: tor bug.png added

Changed 18 months ago by Dbryrtfbcbhgf

Attachment: tor bug stable.png added

comment:1 Changed 18 months ago by Dbryrtfbcbhgf

comment:2 Changed 18 months ago by gk

Cc: arthuredelstein added
Keywords: tbb-fingerprinting-resolution added

comment:3 Changed 18 months ago by gk

Status: newneeds_information

I wonder if that's a new problem with Tor Browser 7. Could you test with an older one (e.g. 6.5.2)? See: https://archive.torproject.org/tor-package-archive/torbrowser/6.5.2/ for bundles. Make sure your test session starts without the security-slider-hint-notification bar which you see on the very first start.

comment:4 in reply to:  3 Changed 18 months ago by Dbryrtfbcbhgf

Replying to gk:

I wonder if that's a new problem with Tor Browser 7. Could you test with an older one (e.g. 6.5.2)? See: https://archive.torproject.org/tor-package-archive/torbrowser/6.5.2/ for bundles. Make sure your test session starts without the security-slider-hint-notification bar which you see on the very first start.

I tested version 6.5.2 and attached a photo of the results.
Browser window width: 1000
Browser window height: 609

Changed 18 months ago by Dbryrtfbcbhgf

Attachment: TBB bug.png added

comment:5 Changed 18 months ago by gk

Interesting. Do you feel like you could test a vanilla Firefox beta (55b10) which is containing the same patches we ship. You can find it on https://ftp.mozilla.org/pub/firefox/releases/55.0b10/mac/en-US/. After first start you need to enable fingerprinting resistance by setting privacy.resistFingerprinting to true. After restarting could you make your test again and share the results in this ticket?

comment:6 in reply to:  5 Changed 18 months ago by Dbryrtfbcbhgf

Replying to gk:

Interesting. Do you feel like you could test a vanilla Firefox beta (55b10) which is containing the same patches we ship. You can find it on https://ftp.mozilla.org/pub/firefox/releases/55.0b10/mac/en-US/. After first start you need to enable fingerprinting resistance by setting privacy.resistFingerprinting to true. After restarting could you make your test again and share the results in this ticket?

I followed all the above directions and here are my results.

Browser window width: 1000

Browser window height: 597

Changed 18 months ago by Dbryrtfbcbhgf

Attachment: firefox.png added

comment:7 Changed 18 months ago by gk

Hm. Where does that "startpages" item come from? Is that a toolbar that is on by default? I wonder whether an older Firefox you had on your computer could cause this and thus interfere with the test.

comment:8 Changed 18 months ago by Dbryrtfbcbhgf

I had the stable version of Firefox installed before a test at the Beta, I can retry to test by first deleting all of Firefox preference files,

comment:9 in reply to:  8 Changed 18 months ago by gk

Replying to Dbryrtfbcbhgf:

I had the stable version of Firefox installed before a test at the Beta, I can retry to test by first deleting all of Firefox preference files,

That might help. Or just creating a new profile via about:profiles and using that one for the test. Thanks!

comment:10 Changed 18 months ago by Dbryrtfbcbhgf

After I deleted all the Firefox preference files I got these results.
Browser window width: 1000
Browser window height: 600
I retested Tor browser bundle 7.0.2 and still got the same results.
Browser window width: 1000
Browser window height: 610

comment:11 Changed 18 months ago by gk

Thanks. Could you test Tor Browser with NoScript and/or HTTPS Everywhere being disabled? Maybe having their toolbar buttons injected into the toolbar is causing this.

comment:12 Changed 18 months ago by Dbryrtfbcbhgf

Posted below

Last edited 18 months ago by Dbryrtfbcbhgf (previous) (diff)

comment:13 Changed 18 months ago by Dbryrtfbcbhgf

Priority: MediumHigh

comment:14 Changed 18 months ago by Dbryrtfbcbhgf

Milestone: Tor: 0.3.2.x-final
Severity: NormalMajor

comment:15 in reply to:  11 Changed 18 months ago by Dbryrtfbcbhgf

Replying to gk:

Thanks. Could you test Tor Browser with NoScript and/or HTTPS Everywhere being disabled? Maybe having their toolbar buttons injected into the toolbar is causing this.

When I disable the torbutton extension but have HTTPS Everywhere and Noscript extensions enabled I get.

Browser window width: 1000

Browser window height: 600

HTTPS Everywhere disabled.
Browser window width: 1000
Browser window height: 610
Noscript disabled
Browser window width: 1000
Browser window height: 610
Both HTTPS Everywhere and Noscript disabled
Browser window width: 1000
Browser window height: 610
When I set the security slider to low I get.
Browser window width: 1000
Browser window height: 610
Tested on TBB 7.0.2

Last edited 18 months ago by Dbryrtfbcbhgf (previous) (diff)

comment:16 Changed 18 months ago by gk

Keywords: tbb-torbutton added
Milestone: Tor: 0.3.2.x-final
Status: needs_informationassigned

Okay, thanks. So, the Torbutton extension is causing this, interesting. Probably as it inserts the button into the toolbar after the window got rounded which makes it larger. Hrm.

comment:17 Changed 17 months ago by gk

Resolving #23264 as a duplicate.

comment:18 Changed 17 months ago by arthuredelstein

comment:19 Changed 17 months ago by arthuredelstein

Keywords: TorBrowserTeam201708R added
Status: assignedneeds_review

comment:20 Changed 17 months ago by cypherpunks

Does this also fix #22543?

comment:21 in reply to:  20 Changed 17 months ago by arthuredelstein

Replying to cypherpunks:

Does this also fix #22543?

Yes, my testing indicates that it does fix that ticket as well as the issues in ticket:22543#comment:2 and ticket:22543#comment:3.

comment:22 Changed 17 months ago by gk

Keywords: TorBrowserTeam201708 added; TorBrowserTeam201708R removed
Status: needs_reviewneeds_revision

Could you split up the patch and do the fullscreen part in a different patch? I know it's just a tiny thing but we have #20375 for this issue and having a patch just for that one in that bug makes it easier to follow things and back things out if necessary.

And could you note in the commit message for the patch for this bug that #22543 gets fixed by your patch as well?

comment:23 in reply to:  22 Changed 17 months ago by arthuredelstein

Keywords: TorBrowserTeam201708R added; TorBrowserTeam201708 removed
Status: needs_revisionneeds_review

Replying to gk:

Good idea. Here are the two patches as requested:

https://github.com/arthuredelstein/torbutton/commits/22989+1

comment:24 Changed 17 months ago by gk

Keywords: tbb-7.0-issues tbb-regression added
Resolution: fixed
Status: needs_reviewclosed

Okay, the patch for this issue looks good and testing on Linux and Windows (I currently don't have a macOS system handy) show no regressions. I applied it to master and maint-1.9.7 (commit 97380447e4ab66a44abed4ec0aeb5eeabf86404e and 6aa6d6ef1355179d7198f0eb09405ac0968ba4e7).

I added a link for the patch for #20375 to the respective ticket setting it to needs_review.

Last edited 17 months ago by arthuredelstein (previous) (diff)
Note: See TracTickets for help on using tickets.