Changes between Initial Version and Version 1 of Ticket #23024, comment 1


Ignore:
Timestamp:
Jul 24, 2017, 4:31:39 PM (2 years ago)
Author:
arthuredelstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23024, comment 1

    initial v1  
    11Here's my patch for review. I would suggest we adding it after we have transitioned to rbm builds:
    2 https://github.com/arthuredelstein/tor-browser/commit/23024
     2https://github.com/arthuredelstein/tor-browser-build/commit/23024
    33
    44I tried building TBB with `-fstack-protector-strong` on mingw-w64 but so far ran into [https://sourceforge.net/p/mingw-w64/discussion/723798/thread/de524c41/#e4f9 errors]. However, a Windows Tor Browser built with this patch (using `-fstack-protector-all`) doesn't seem subjectively slower to me, so I would suggest trying this on the alpha, at least until we have a solution for `-fstack-protector-strong` on mingw-w64.