Opened 3 weeks ago

Closed 3 weeks ago

#23030 closed defect (fixed)

Review coverity build warnings

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 029-backport 030-backport 031-backport coverity
Cc: Actual Points: .1
Parent ID: Points:
Reviewer: Sponsor: SponsorV-can

Description

Coverity emits a big pile of build warnings because of our BUG macro. Let's see if we can fix that. They look like this:

"/home/torcoverity/src/tor/cov-int/emit/totoro.wangafu.net/config/fc74ea42bbd56
          ee35d2b17ca574b8e9b/gcc-config-0/coverity-compiler-compat.h", line
          1627: warning #41: expression must have arithmetic or pointer type
  #nodef BUG() __coverity_panic__()

Also, there are quite a few of these:

"src/common/util.c", line 1169: warning #1563: function "tor_parse_long" not
          emitted, consider modeling it or review parse diagnostics to improve
          fidelity
  tor_parse_long(const char *s, int base, long min, long max,

Child Tickets

Change History (6)

comment:1 Changed 3 weeks ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 weeks ago by nickm

Keywords: 029-backport 030-backport 031-backport coverity added
Sponsor: SponsorV-can

comment:3 Changed 3 weeks ago by nickm

Actual Points: 1
Status: acceptedneeds_review

My branch bug23030_029 has a fix here. I think we should merge it at least into master.

comment:4 Changed 3 weeks ago by nickm

Actual Points: 1.1

comment:5 Changed 3 weeks ago by ahf

Status: needs_reviewmerge_ready

Hard to test locally, but looks good to me. Let's get it in and see how Coverity handles it.

comment:6 Changed 3 weeks ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.2.9.x-final
Resolution: fixed
Status: merge_readyclosed

Cherry-picked to bug23030_029_v2 and merged to 0.2.9 and forward.

Note: See TracTickets for help on using tickets.