Opened 17 months ago

Last modified 16 months ago

#23043 new defect

leekspin's except/error code handling in generator.py is strange

Reported by: Samdney Owned by: isis
Priority: Low Milestone:
Component: Obfuscation/BridgeDB Version:
Severity: Minor Keywords: leekspin
Cc: Actual Points:
Parent ID: #23333 Points:
Reviewer: Sponsor:

Description

In /leekspin/generator.py you have in "def createRelayOrBridgeDescriptors(...)"

Code highlighting:

def createRelayOrBridgeDescriptors(count, bridge=True, **kwargs):
  ...
  try:
    ...
  except KeyboardInterrupt as keyint:
    logging.warn("Received keyboard interrupt.")
    logging.warn("Stopping descriptor creation and exiting.")
    code = 1515
  finally:
    ...
    logging.info("Done.")
    code = 0
    sys.exit(code)

The same in a similiar way also in "def createHiddenServiceDescriptors(...)"

I think your way of handling the code-variable isn't right. If you have an Keyboard exception if follows: code = 1515. But the "try ... except ... finally" - block always "finally" execute the code within the finally block. So it will always exit with code = 0, sys.exit(0)!

In generally, the execution of (some) parts of the finally block after an keyboard interruption makes no sense for me.

(I haven't found time to examinate the full source code until now. Hence, for the case that all has a good reason, please ignore me :)

Child Tickets

Change History (1)

comment:1 Changed 16 months ago by Samdney

Parent ID: #23333
Note: See TracTickets for help on using tickets.