Opened 3 years ago

Last modified 2 years ago

#23066 new defect

Test granularity, distribution, and inner range of crypto_rand* functions

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt, test, easy, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor: SponsorQ-can

Description

In #23061, we added tests for crypto_rand_double() that test:

  • granularity: low bits being non-zero,
  • distribution: some values above and below half, and
  • inner range: mock crypto_rand() and generate lowest and highest valid results.

We should do the same for:

  • crypto_rand()
  • crypto_rand_int()
  • crypto_rand_int_range()
  • crypto_rand_uint64()
  • crypto_rand_uint64_range()
  • crypto_rand_time_range()
  • crypto_rand_hostname()

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by nickm

Sponsor: → SponsorQ-can

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.3.3.x-final → Tor: 0.3.4.x-final

Defer a small handful of non-enhancement "new" tickets to 0.3.4

comment:3 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:4 Changed 2 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:5 Changed 2 years ago by nickm

Milestone: Tor: 0.3.4.x-final → Tor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.