Opened 8 weeks ago

Closed 7 weeks ago

#23078 closed defect (implemented)

hs: Forgotten log_warn for prop224 intro point

Reported by: dgoulet Owned by: dgoulet
Priority: High Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, tor-relay, 030-backport, 031-backport
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

Turns out we forgot to remove that log statement from hs_intropoint.c:

  log_warn(LD_GENERAL, "Established prop224 intro point on circuit %" PRIu32,
           circ->p_circ_id);

It has been reported here: https://lists.torproject.org/pipermail/tor-relays/2017-August/012689.html

As far as I can tell, it seems the only warning that is misplaced and that one is unneeded.

However, I might want to take the opportunity to change 3 log_warn() and put them to protocol warning level instead.

    log_warn(LD_REND, "Unable to send INTRODUCE2 cell to the service.");
...
    log_warn(LD_REND, "Unable to send an INTRODUCE ACK status %d to client.",
             status);
...
    log_warn(LD_BUG, "Couldn't send INTRO_ESTABLISHED cell.");

They've been introduced in tor-0.3.0.1-alpha and tor-0.3.0.2-alpha.

Child Tickets

Change History (4)

comment:1 Changed 8 weeks ago by dgoulet

Keywords: 030-backport 031-backport added

See branch based on 030: bug23078_030_01

comment:2 Changed 8 weeks ago by dgoulet

Status: newneeds_review

comment:3 Changed 7 weeks ago by nickm

lgtm; merged to 0.3.0 and forward.

comment:4 Changed 7 weeks ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.0.x-final
Resolution: implemented
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.