Opened 3 months ago

Closed 3 months ago

#23098 closed defect (implemented)

FTBFS again on Hurd

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: gnuhurd
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is another case of #5355 which was introduced by ba3a5f82f11388237a3ba4995ddf0b6ffaaf492a. Found this while looking at the Tor builds on Debian (see https://buildd.debian.org/status/logs.php?pkg=tor&arch=hurd-i386).

Child Tickets

Attachments (3)

Change History (7)

Changed 3 months ago by cypherpunks

comment:1 Changed 3 months ago by cypherpunks

Status: newneeds_review

comment:2 Changed 3 months ago by asn

Keywords: gnuhurd added
Milestone: Tor: 0.3.2.x-final

comment:3 Changed 3 months ago by nickm

The approach in 0002 needs a tweak: if a value is allocated with malloc() directly, we should make sure to copy it with tor_malloc(), since we do not guarantee that platform malloc and tor_malloc() are equally compatible with tor_free() and free(). (qv our dmalloc support.)

I'll merge and make this change.

comment:4 Changed 3 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Squashed and merged. My tweak is in 89407bedf8980b9dd7a10b268b351e8b2938ac80

Note: See TracTickets for help on using tickets.