Changes between Initial Version and Version 1 of Ticket #23101, comment 14


Ignore:
Timestamp:
Dec 11, 2017, 12:31:03 PM (17 months ago)
Author:
asn
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23101, comment 14

    initial v1  
    11Initial review performed here on oniongit. This one is a hard and complicated feature to do well and clean. Let's do it!
    22
    3 I'm a bit anxious about the new purpose added here, and how well it's handled by the whole codebase. I'd really like a way to test this new purpose, either unittest or integration test (currently all the integration tests fail `make test-network-all` because of #13837 issues).
     3I'm a bit anxious about the new purpose added here, and how well it's handled by the whole codebase. I'd really like a way to test this new purpose, either unittest or integration test (currently all the integration tests fail `make test-network-all` because of #13837 issues). After a few #13837/#23101 fixes get in I'll also give the `vanguard` project a try.