Changes between Initial Version and Version 1 of Ticket #23101, comment 33


Ignore:
Timestamp:
Jan 18, 2018, 7:58:10 PM (17 months ago)
Author:
mikeperry
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23101, comment 33

    initial v1  
    99
    1010This did not strike me as simpler, especially since "is_internal" doesn't always seem to mean "internal for HS activity only", like for router descriptor downloads and who knows what else in the future. I wanted to keep it completely and obviously separate.
     11
     12Oh, also using is_internal means that there is some possibility of use confusion if a controller is SETCONFing these options. Then there could be some old C_GENERAL is_internal circuits that are not pinned laying around after the SETCONF. We do try to mark all of these dirty, but it is not as easy for the controller to track them and verify correctness if they do not have a unique purpose.