Changes between Initial Version and Version 1 of Ticket #23101, comment 9


Ignore:
Timestamp:
Nov 29, 2017, 12:19:17 PM (16 months ago)
Author:
asn
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23101, comment 9

    initial v1  
    2222
    2323Another behavior worth documenting: I wonder how the predictive circuit launching should work after this change. Should clients create predictive general circuits and also create predictive HS circuits? What about HSes?
    24 
    25 > In terms of how this will be done - I am going to alter circuit_find_to_cannibalize() so that you must also specify a circuit type to cannibalize from in addition to the one you want to create, and you can't switch between these classes of circuits (in the case where there is nothing to cannibalize in this way, that function can find nothing and return NULL, and the calling code in circuit_launch_by_extend_info() will build a fresh circuit instead). Since circuit_find_to_cannibalize() already behaves as if you specified canibalize_from == CIRCUIT_PURPOSE_C_GENERAL, I don't anticipate that the change to draw from CIRCUIT_PURPOSE_HS_GENERAL will be very complicated.