Changes between Initial Version and Version 1 of Ticket #23104, comment 11


Ignore:
Timestamp:
Sep 20, 2017, 11:11:48 AM (22 months ago)
Author:
gk
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23104, comment 11

    initial v1  
    1 Looks good to me and works on Linux and Windows as at least. The test passes as well. I wonder, though, how future-proof the test is assuming the factor 1.2 comes from `NORMAL_LINE_HEIGHT_FACTOR`? Adding some folks for a second review.
     1Looks good to me and works on Linux and Windows at least. The test passes as well. I wonder, though, how future-proof the test is assuming the factor 1.2 comes from `NORMAL_LINE_HEIGHT_FACTOR`? Adding some folks for a second review.