Opened 4 months ago

Last modified 3 months ago

#23107 new defect

prop224: Optimize hs_circ_service_get_intro_circ() digest calculation

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop224, prop224-extra, tor-hs, optimization, 032-unreached
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: Sponsor: SponsorR-can

Description

Our prop224 function for getting an intro circ given its intro object re-calculates the relay identity fpr all the time:

  if (ip->base.is_only_legacy) {
    uint8_t digest[DIGEST_LEN];
    if (BUG(crypto_pk_get_digest(ip->legacy_key, (char *) digest) < 0)) {
      goto end;
    }
    circ = hs_circuitmap_get_intro_circ_v2_service_side(digest);

We could shove that in the hs_service_intro_point_t object as well to cut some digest calculations.

Child Tickets

Change History (1)

comment:1 Changed 3 months ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

Note: See TracTickets for help on using tickets.