Opened 2 years ago

Closed 2 years ago

#23130 closed defect (implemented)

prop224: Synchronize spec with implementation (August 2017)

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop224 tor-hs tor-spec
Cc: Actual Points:
Parent ID: #23300 Points: 0.4
Reviewer: Sponsor: SponsorR-can

Description

During implementation and reviewing we noticed a few more deviations of the implementation from the spec, and also some spec errors.

Here is a list:

1) RENDEZVOUS2 is not identical to RENDEZVOUS1 since rend points strips out the rend cookie.

2) We use a replaycache for the rendcookie when parsing intro2 on the service-side

3) No legacy INTRODUCE cell anymore since that was not needed.

4) We can have multiple intro onion keys with different types on the HS desc (see #22979)

5) We need to mention the ed25519 base point in the spec since we use it hardcoded in the code.

We might get more items here as client-side review moves forward.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by dgoulet

Parent ID: #17242#23300

Switching parent to client side issues ticket.

comment:2 Changed 2 years ago by asn

Status: newneeds_review

Pushed branch here with various spec improvements!

The last commit is the most controversial one since it kills some TODOs and changes author list and acknowledgements. Let me know if you don't like it and we can take it out.

comment:3 Changed 2 years ago by asn

Branch is at bug23130

Last edited 2 years ago by asn (previous) (diff)

comment:4 Changed 2 years ago by nickm

lgtm! And yes, you and David should definitely be in the authors list.

comment:5 Changed 2 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.