Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2314 closed defect (fixed)

Compile warnings on windows

Reported by: Sebastian Owned by:
Priority: Medium Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

maint-0.2.1, -0.2.2 and master all have compile warnings on windows for me. I'll provide some branches with fixes. Do we care about harmless 0.2.1 warnings?

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by Sebastian

Here are the maint-0.2.1 warnings:

crypto.c: In function 'crypto_seed_rng':
crypto.c:1810:3: warning: pointer targets in passing argument 3 of 'CryptGenRandom' differ in signedness
c:\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/wincrypt.h:1204:23: note: expected 'PBYTE' but argument is of type 'char *'


config.c: In function 'is_listening_on_low_port':
config.c:2667:35: warning: unused parameter 'port_option'
config.c:2668:47: warning: unused parameter 'listen_options'


cpuworker.c: In function 'cpuworker_main':
cpuworker.c:244:5: warning: pointer targets in passing argument 2 of 'recv' differ in signedness
c:\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winsock2.h:547:32: note: expected 'char *' but argument is of type 'uint8_t *'


ntmain.c: In function 'nt_service_install':
ntmain.c:550:17: warning: comparison with string literal results in unspecified behavior



eventdns.c: In function 'nameserver_read':
eventdns.c:1298:9: warning: pointer targets in passing argument 2 of 'recvfrom' differ in signedness
c:\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winsock2.h:548:32: note: expected 'char *' but argument is of type 'uint8_t *'
eventdns.c: In function 'server_port_read':
eventdns.c:1329:15: warning: pointer targets in passing argument 2 of 'recvfrom' differ in signedness
c:\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winsock2.h:548:32: note: expected 'char *' but argument is of type 'uint8_t *'
eventdns.c: In function 'evdns_request_transmit_to':
eventdns.c:2062:2: warning: pointer targets in passing argument 2 of 'send' differ in signedness
c:\mingw\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winsock2.h:549:32: note: expected 'const char *' but argument is of type 'uint8_t *'

comment:2 Changed 9 years ago by Sebastian

Status: newneeds_review

On irc arma confirmed that we don't care about fixing the compile warnings for 0.2.1, so bug2314 has them for 0.2.2. Merges cleanly into master. (Should we later decide to backport: the warnings in config.c where fixed already so need to be fixed in the backport manually)

Hudson now manages to build 0.2.2 and master without warnings if my fixes for 2313 and 2314 are merged as in my fake_maint_022_for_hudson and fake_master_for_hudson branches.

comment:3 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks okay, merged this one into 0.2.2 and master.

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.