#23163 closed defect (fixed)

Wrong name for new tor config options

Reported by: atagar Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-config, 032-unreached
Cc: Actual Points:
Parent ID: #12541 Points:
Reviewer: Sponsor:

Description (last modified by arma)

Hi Nick, tor has three new config options where the double unscore should be at the start rather than end...

SchedulerHighWaterMark__  101 MB                                                                                                                  
SchedulerLowWaterMark__   100 MB
SchedulerMaxFlushCells__  1000

Lacking this causes applications (like Nyx) to present these as user-facing options rather than a hidden option like __ReloadTorrcOnSIGHUP.

Cheers! -Damian

Child Tickets

Change History (8)

comment:1 Changed 23 months ago by arma

Not disputing the rest, but, are you sure they're new? :) Looks like they went into git commit b1e1b439 which went into Tor

comment:2 Changed 23 months ago by arma

Description: modified (diff)

comment:3 Changed 23 months ago by atagar

Hi Roger. Sorry, I didn't check that they are new so you're no doubt completely right. Just noticed these since they popped up while I was getting back into Nyx development.

comment:4 Changed 23 months ago by nickm

Another wrinkle: I do not remember why these options had __s after them. I think they were meant to be temporary, rather than hidden? I wonder if KIST will replace them.

Last edited 23 months ago by nickm (previous) (diff)

comment:5 Changed 22 months ago by dgoulet

Keywords: tor-config added
Milestone: Tor: 0.3.2.x-final
Parent ID: #12541

Putting the KIST ticket as parent because it's possible they get changed or something.

comment:6 Changed 21 months ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Move some 0.3.2 items (fewer than I had expected for now) into Unspecified.

comment:7 Changed 21 months ago by pastly

This can be closed with the force of 1000 suns once its parent (kist!) is merged. (They will no longer be torrc options)

Last edited 21 months ago by pastly (previous) (diff)

comment:8 Changed 21 months ago by pastly

Resolution: fixed
Status: newclosed

They are now marked obsolete in config.c and unused. See b2c56eacdd

Note: See TracTickets for help on using tickets.