Opened 2 years ago

Last modified 17 months ago

#23168 needs_revision defect

Guard sample calls relay descriptors a "consensus"

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.0.9
Severity: Normal Keywords: tor-log, easy, review-group-24, 033-triage-20180320, 033-removed-20180320
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description (last modified by teor)

[info] router_load_routers_from_string: 96 elements to add
[info] sampled_guards_update_from_consensus: Updating sampled guard status based on received consensus.

The message should either say "received directory document(s)", or actually describe the directory document it just received.

Child Tickets

Attachments (1)

001-desriptive_msg.patch (971 bytes) - added by neel 23 months ago.
Patch to change "Updating sampled guard status based on received consensus" message to more descriptive "Received directory document(s) on DATE"

Download all attachments as: .zip

Change History (8)

comment:1 Changed 2 years ago by teor

Description: modified (diff)

Changed 23 months ago by neel

Attachment: 001-desriptive_msg.patch added

Patch to change "Updating sampled guard status based on received consensus" message to more descriptive "Received directory document(s) on DATE"

comment:2 Changed 23 months ago by neel

I have a patch to address this. It's filename is 001-desriptive_msg.patch​.

Please tell me that you think about this.

-Neel

comment:3 Changed 22 months ago by nickm

Keywords: review-group-24 added
Status: newneeds_review

comment:4 Changed 22 months ago by nickm

Status: needs_reviewneeds_revision

Thanks for the patch! Maybe it would make more sense to say "Updating sampled guard status based on directory documents received at %s."?

Also, there's something I don't understand: why are we reporting gs->last_time_on_internet as the time when the documents were received?

comment:5 Changed 17 months ago by nickm

Keywords: 033-triage-20180320 added

Marking all tickets reached by current round of 033 triage.

comment:6 Changed 17 months ago by nickm

Keywords: 033-removed-20180320 added

Mark all not-already-included tickets as pending review for removal from 0.3.3 milestone.

comment:7 Changed 17 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: unspecified

These tickets were marked as removed, and nobody has said that they can fix them. Let's remember to look at 033-removed-20180320 as we re-evaluate our triage process, to see whether we're triaging out unnecessarily, and to evaluate whether we're deferring anything unnecessarily. But for now, we can't do these: we need to fix the 033-must stuff now.

Note: See TracTickets for help on using tickets.