Opened 3 years ago

Closed 3 years ago

#23211 closed enhancement (fixed)

limit Onionoo default listening to localhost

Reported by: iwakeh Owned by: metrics-team
Priority: Medium Milestone: Onionoo-1.4.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


This means shipping a jetty.xml with the following change:

      <New class="org.eclipse.jetty.server.ServerConnector">
          <Ref id="server"/>
        <Set name="port">8080</Set>
+       <Set name="host"></Set>

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by karsten

Sounds like a good idea!

Mostly out of curiosity: How difficult would it be for somebody to override the host setting there? And what would it take to change the port setting? If these things are easy to do, should we document them somewhere?

comment:2 Changed 3 years ago by iwakeh

Milestone: Onionoo-1.4.0

comment:3 Changed 3 years ago by iwakeh

Status: newneeds_review

I added documentation for changing jetty options. Onionoo's jetty is only configured via jetty.xml. Thus, it suffices to state this in the docs and point to the official Jetty documentation.

(I noticed that Onionoo's docs are a little out-of-date. => new ticket #23348)

Please review this patch.

comment:4 Changed 3 years ago by karsten

Status: needs_reviewmerge_ready

Looks good, ready to be merged! (Will do that tomorrow.)

comment:5 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Merged! Closing.

Note: See TracTickets for help on using tickets.