Opened 2 years ago

Closed 2 years ago

#23219 closed defect (wontfix)

CSS issues with <input type="checkbox">

Reported by: rngnrs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-usability-website
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I make a checkbox with a custom label which is contained data-label using :after pseudoelement.

This works fine in Chromium and Firefox but not in Tor Browser.

Also -moz-appearance: none; doesn't work correctly. It should hide the checkbox but it makes it default.

Here is the demo: https://jsfiddle.net/rwcrhj39/

I'm running Tor Browser 7.0.4 on Windows and Ubuntu.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by cypherpunks

Keywords: tbb-usability-website added; css pseudoelement checkbox input removed
Status: newneeds_information

Do you mean Firefox 52 ESR by Firefox?

comment:2 Changed 2 years ago by rngnrs

Oh, I mean Firefox 54. I tried Firefox 52.3.0 ESR -- the same problem: it isn't a TBB bug. In next Firefox versions this bug is fixed.

Another question: when will TBB be updated to new Firefox?

comment:3 Changed 2 years ago by gk

Tor Browser will be updated in about 10 months to the next Firefox ESR (59). So, it'll be a while... That said, could you find out which Mozilla bug fixed your problem? If the patch is not too involved we could think about backporting it.

comment:4 Changed 2 years ago by rngnrs

Yep, there is a patch in 54 version.

https://bugzilla.mozilla.org/show_bug.cgi?id=605985

https://bugzilla.mozilla.org/show_bug.cgi?id=1320751 (refers to 605985)

I would be grateful for these fixes.

comment:6 Changed 2 years ago by gk

Resolution: wontfix
Status: needs_informationclosed

Looking over the bug (https://bugzilla.mozilla.org/show_bug.cgi?id=605985) and following the discussion in comment 88 ff. it seems to me Mozilla made the decision to land all relevant patches (not just the two ones you mentioned in comment:5) in Firefox 54 as they were kind of dependent and chances were high that they would run into regressions if done otherwise.

I think we should follow Mozilla here and not land just those two patch sets. Unfortunately, there are now quite some patches involved and some bugs are still open which complicates the whole issue. It think we should not take the risk involved in the backoprt and wait until this is available when we switch to ESR 59. Sorry for that.

Note: See TracTickets for help on using tickets.