Opened 3 years ago

Closed 3 months ago

#23225 closed defect (fixed)

GetTor should ignore quoted keywords in email replies that quote the help message

Reported by: catalyst Owned by: cohosh
Priority: Medium Milestone:
Component: Applications/GetTor Version:
Severity: Normal Keywords: anti-censorship-roadmap-2020Q1
Cc: cohosh Actual Points:
Parent ID: #9036 Points: 1
Reviewer: phw Sponsor:

Description

If I send an email with the subject "help" to GetTor, and then send an "blank reply that quotes the entire message, I get the links for OrBot for Android (presumably because that's the first recognized keyword in the quoted reply. It's not clear to me what a "blank" reply should produce in response to a help message, maybe a more detailed help message? If there is no more detailed help available, maybe don't mention the blank message option?

Child Tickets

Change History (15)

comment:1 Changed 19 months ago by traumschule

Parent ID: #9036

Let #9036 adopt some children.

comment:2 Changed 8 months ago by cohosh

Cc: cohosh added

cc'ing cohosh on open GetTor tickets.

comment:3 Changed 8 months ago by gaba

Owner: ilv deleted
Status: newassigned

Removing ilv as onwer of many of the tickets. He can take back the ticket he will work on if he comes back into gettor.

comment:4 Changed 8 months ago by gaba

Status: assignednew

comment:5 Changed 4 months ago by cohosh

Points: 1

comment:6 Changed 4 months ago by gaba

Keywords: anti-censorship-roadmap-2020Q1 added

comment:7 Changed 4 months ago by cohosh

Owner: set to cohosh
Status: newassigned

Update of the current status:

Some things have changed with GetTor, so the behaviour described in the description is slightly different now. If you reply to the help email now, you will simply get another help email because GetTor recognizes the help keyword in the subject line
Re: [GetTor] Help Email

We still want to parse the email subject, but we should prioritize parsing the body of the email first and ignore reply text.

We may also want to include some help text along with GetTor links, in a way similar to our bridgedb emails in #30941

comment:8 Changed 4 months ago by cohosh

Status: assignedneeds_review

Here's a commit that will ignore quoted text and prioritize the link command for GetTor, along with some tests: https://dip.torproject.org/cohosh/gettor/merge_requests/6

comment:9 Changed 4 months ago by cohosh

Reviewer: phw

comment:10 Changed 4 months ago by phw

Status: needs_reviewneeds_revision

I left a bunch of comments and questions in the PR.

FWIW, we recently fixed a similar issue (#17626) in BridgeDB; also by ignoring quoted commands.

comment:11 Changed 4 months ago by teor

Some popular email clients quote messages by top-posting, then including the original message after a header. (For example, Microsoft Outlook.)

This behaviour might also affect the BridgeDB changes in #17626.

Last edited 4 months ago by teor (previous) (diff)

comment:12 Changed 4 months ago by cohosh

Status: needs_revisionneeds_review

Thanks! This feedback was useful. I added a few more test cases to capture the feedback from both phw and teor, as well as some fixes to the code.

comment:13 Changed 3 months ago by phw

Status: needs_reviewmerge_ready

LGTM!

comment:14 in reply to:  11 Changed 3 months ago by phw

Replying to teor:

Some popular email clients quote messages by top-posting, then including the original message after a header. (For example, Microsoft Outlook.)

This behaviour might also affect the BridgeDB changes in #17626.


Good point but this shouldn't affect BridgeDB's email parser.

comment:15 Changed 3 months ago by cohosh

Resolution: fixed
Status: merge_readyclosed

Merged at f31e18f0

Deployed to gettor-01

2020-03-12T17:18:05+0000 [gettor#info] Starting services.
Note: See TracTickets for help on using tickets.