Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

We are getting the following error when trying to build firefox for Windows 64:

/var/tmp/build/firefox-af0ca6a886c7/media/libcubeb/src/cubeb_wasapi.cpp:1596:46:
 error: cast from cubeb_devid {aka void*} to int loses precision
 [-fpermissive]

added TorBrowserTeam201708R component::applications/tor browser owner::boklm parent::23229 priority::medium resolution::fixed severity::normal status::closed type::task labels

Trac:
0001-Bug-23230-Fix-build-error-on-Windows-64.patch

I attached a patch that is fixing this error.

Trac:
Keywords: N/A deleted, TorBrowserTeam201708R added
Status: assigned to needs_review

FWIW: commit 5abde564516a8557266159bfe25d9e046ea9d318 shows how upstream (https://github.com/kinetiknz/cubeb) avoids casting to int. It missed ESR 52, though, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1314514.

Looks good to me. Let's see what others think.

Trac:
Cc: tbb-team to tbb-team, mcs, brade

r=mcs This looks good to me also.

That's commit f36d2a2dd30368c97594923092a43dd74c61846c on tor-browser-52.3.0esr-7.5-2 now, thanks.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c7, they updated in-tree libcubeb to fix security issue, crash and incompatibility with Gecko. Why don't you do the same?

Replying to cypherpunks:

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c7, they updated in-tree libcubeb to fix security issue, crash and incompatibility with Gecko. Why don't you do the same?

Because we are following esr52 as close as we can to avoid diverting too much from it as this is quite risky. Apart from that the security issue is fixed in esr52. Not sure which crash and incompatibility you are talking about, though.

https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c15 It was landed on trunk a week after ESR had been moved to alpha. It is the library of Firefox, in fact. The divergence should be minimal. They had to update ESR, but preferred cherry-picking :(

closed

moved to tpo/applications/tor-browser#23230 (closed)