Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#23230 closed task (fixed)

Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201708R
Cc: tbb-team, mcs, brade Actual Points:
Parent ID: #23229 Points:
Reviewer: Sponsor:

Description

We are getting the following error when trying to build firefox for Windows 64:

/var/tmp/build/firefox-af0ca6a886c7/media/libcubeb/src/cubeb_wasapi.cpp:1596:46:
 error: cast from cubeb_devid {aka void*} to int loses precision
 [-fpermissive]

Child Tickets

Attachments (1)

0001-Bug-23230-Fix-build-error-on-Windows-64.patch (1.7 KB) - added by boklm 16 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 16 months ago by boklm

Keywords: TorBrowserTeam201708R added
Status: assignedneeds_review

I attached a patch that is fixing this error.

comment:2 Changed 16 months ago by gk

FWIW: commit 5abde564516a8557266159bfe25d9e046ea9d318 shows how upstream (https://github.com/kinetiknz/cubeb) avoids casting to int. It missed ESR 52, though, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1314514.

comment:3 Changed 16 months ago by gk

Cc: mcs brade added

Looks good to me. Let's see what others think.

comment:4 Changed 16 months ago by mcs

r=mcs
This looks good to me also.

comment:5 Changed 16 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

That's commit f36d2a2dd30368c97594923092a43dd74c61846c on tor-browser-52.3.0esr-7.5-2 now, thanks.

comment:6 Changed 16 months ago by cypherpunks

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c7, they updated in-tree libcubeb to fix security issue, crash and incompatibility with Gecko. Why don't you do the same?

comment:7 in reply to:  6 Changed 16 months ago by gk

Replying to cypherpunks:

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c7, they updated in-tree libcubeb to fix security issue, crash and incompatibility with Gecko. Why don't you do the same?

Because we are following esr52 as close as we can to avoid diverting too much from it as this is quite risky. Apart from that the security issue is fixed in esr52. Not sure which crash and incompatibility you are talking about, though.

comment:8 Changed 16 months ago by cypherpunks

https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c15
It was landed on trunk a week after ESR had been moved to alpha. It is the library of Firefox, in fact. The divergence should be minimal. They had to update ESR, but preferred cherry-picking :(

Note: See TracTickets for help on using tickets.