Opened 6 months ago

Closed 3 months ago

#23262 closed defect (fixed)

implement integrated progress bar for new Tor Launcher UI

Reported by: mcs Owned by: brade
Priority: Very High Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: ux-team, TorBrowserTeam201711R
Cc: linda Actual Points:
Parent ID: #21951 Points:
Reviewer: Sponsor: Sponsor4

Description (last modified by mcs)

This ticket tracks implementation of integrated progress bar for the new Tor Launcher configuration UI, as found here: ​https://marvelapp.com/3f6102d/

The work to implement the new configuration UI is tracked in #23261.

Child Tickets

Attachments (1)

overlaid-error.png (87.4 KB) - added by mcs 5 months ago.
an example of an overlaid error

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 months ago by mcs

Description: modified (diff)

comment:2 Changed 6 months ago by gk

Keywords: TorBrowserTeam201709 added
Sponsor: Sponsor4

Changed 5 months ago by mcs

Attachment: overlaid-error.png added

an example of an overlaid error

comment:3 Changed 5 months ago by mcs

Work-in-progress patches are available on the newui branch within the brade tor-launcher repo, here: https://gitweb.torproject.org/user/brade/tor-launcher.git/log/?h=newui

Note that we have rebased that branch a few times so far and we may do so again.

The implementation is now close to Linda's latest specification, minus the fancy progress bar with icons. We did make an enhancement that is not part of Linda's specification: some errors that previously generated separate alert windows are now displayed using an overlay, like this:

an example of an overlaid error

We did this as part of a general effort to reduce Tor Launcher's use of alert windows; while trying to fix #21542 we found that they cause problems (that ticket is on hold for now, but we plan to come back to it).

If you want to try the new Tor Launcher experience without building from source, follow the instructions in ticket:23261#comment:3 (we replaced the .xpi file on people.torproject.org with a new one). We still have some loose ends to address, but comments and bug reports are welcome.

comment:4 Changed 5 months ago by gk

Keywords: TorBrowserTeam201710 added; TorBrowserTeam201709 removed

Items for October 2017

comment:5 Changed 4 months ago by mcs

Keywords: TorBrowserTeam201710R added; TorBrowserTeam201710 removed
Status: newneeds_review

Please review the two most recent patches on the bug23261-01 branch, here:
https://gitweb.torproject.org/user/brade/tor-launcher.git/log/?h=bug23261-01
(the changes for this ticket require the #23261 changes).

The changes are also available as part on the following oniongit merge request:
https://oniongit.eu/brade/tor-launcher/merge_requests/2

comment:6 in reply to:  3 Changed 4 months ago by linda

The implementation is now close to Linda's latest specification, minus the fancy progress bar with icons. We did make an enhancement that is not part of Linda's specification: some errors that previously generated separate alert windows are now displayed using an overlay, like this:

an example of an overlaid error

We did this as part of a general effort to reduce Tor Launcher's use of alert windows; while trying to fix #21542 we found that they cause problems (that ticket is on hold for now, but we plan to come back to it).

I think that this is a good idea! Glad you did this.

comment:7 Changed 4 months ago by mcs

The multi-step progress bar now has its own ticket: #23971.

comment:8 Changed 4 months ago by gk

Keywords: TorBrowserTeam201711R added; TorBrowserTeam201710R removed

Moving review to November

comment:9 Changed 4 months ago by gk

Priority: MediumVery High

Changing prio to reflect sponsor deadline

comment:10 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.