Opened 2 years ago

Closed 20 months ago

#23265 closed enhancement (wontfix)

Make addon update failures more obvious somehow.

Reported by: yawning Owned by: yawning
Priority: Medium Milestone:
Component: Archived/Tor Browser Sandbox Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Ever since the switch to make extensions be read only bind-mounted files into a temporary tmpfs dir, manual addon updates appear to work, even though the updates will not actually persist.

Instead attempting to update addons should fail immediately, as the behavior is probably confusing to users.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by yawning

https://gitweb.torproject.org/tor-browser/sandboxed-tor-browser.git/commit/?id=65ef5ea681e6836a95ec161d5de4b831fc8c21f9

This fixes everything except for HTTPS-E. I'm not sure what I should do about the last case, because it's not immediately obvious to me how to override the update URL when it's set in an addon's install.rdf file.

Maybe #10394 will solve this for me.

comment:2 in reply to:  1 ; Changed 2 years ago by cypherpunks

Replying to yawning:

This fixes everything except for HTTPS-E. I'm not sure what I should do about the last case, because it's not immediately obvious to me how to override the update URL when it's set in an addon's install.rdf file.

Use the version from AMO ;)

comment:3 in reply to:  2 Changed 2 years ago by yawning

Replying to cypherpunks:

Replying to yawning:

This fixes everything except for HTTPS-E. I'm not sure what I should do about the last case, because it's not immediately obvious to me how to override the update URL when it's set in an addon's install.rdf file.

Use the version from AMO ;)

In general replacing large bundle components wholesale is omething I want to avoid. I could also modify the install.rdf file, but that will cause issues with the delta updater and XPI signatures.

comment:4 Changed 2 years ago by cypherpunks

Ask TBB Team for that ;) (as EFF special updating sucks the same way nowadays)

comment:5 in reply to:  4 Changed 2 years ago by yawning

Replying to cypherpunks:

Ask TBB Team for that ;) (as EFF special updating sucks the same way nowadays)

I did. Among other things that Tor Browser should be doing, some dating back years.

Ultimately it's up to the Tor Browser people to change how addons are built, packaged, and shipped at this point. The sandbox doesn't auto update addons individually, and if people try to manually update them, it won't actually work regardless of what the UI says.

I'm not going to take further action here till the upstream situation changes.

comment:6 Changed 20 months ago by yawning

Resolution: wontfix
Status: newclosed

This project is deprecated, and none of these will ever be fixed.

Note: See TracTickets for help on using tickets.