Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2327 closed defect (fixed)

Bufferevents SOCKS client code crashes

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From #tor:

2010-12-19 07:20 <piebeer> evbuffer_pullup(buf, 128) returns NULL, for fetch_from_evbuffer_socks_client() there are not so much as 128 bytes in the buf.
2010-12-19 08:53 <piebeer> Hi. anyone using 0.2.3.x-alpha with libevent2 and Socks4Proxy (or Socks5Proxy) option used?

Another user has now reported a crash traced to fetch_from_evbuffer_socks_client.

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by rransom

Status: newneeds_review

See bug2327 ( ssh://mob@repo.or.cz/srv/git/tor/rransom.git bug2327 ) for a fix for this bug, and another that I found while looking at the same function.

Does this need a changes file?

comment:2 Changed 9 years ago by Sebastian

Fix looks good to me. Changes file not necessary because the bug was introduced in an unreleased version.

comment:3 Changed 9 years ago by rransom

See bug2327-v2 ( ssh://mob@repo.or.cz/srv/git/tor/rransom.git bug2327-v2 ) for slightly improved commit messages.

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks fine to me; merging.

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.