Opened 3 years ago

Closed 3 years ago

#23305 closed defect (implemented)

hs: Maybe don't use REND_DESC_ID_V2_LEN_BASE32 as the length for a base32 relay digest id

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, easy, refactor
Cc: #23300 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Function hs_lookup_last_hid_serv_request() defines an HSDir identity digest in base32 as:

  char hsdir_id_base32[REND_DESC_ID_V2_LEN_BASE32 + 1];

Although the length is correct, semantically this is bad to use the base32 descriptor ID length for this.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

comment:2 Changed 3 years ago by dgoulet

Status: acceptedneeds_review

Branch ticket23305_032_01

comment:3 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed


Note: See TracTickets for help on using tickets.