Opened 3 years ago

Last modified 2 weeks ago

#23306 new defect

hs: Use the state of a directory connection instead of the HAS_FETCHED purpose

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #23300 Points:
Reviewer: Sponsor: SponsorR-can

Description

Hidden service client directory connection switch their purpose to DIR_PURPOSE_HAS_FETCHED_RENDDESC_V2 and DIR_PURPOSE_HAS_FETCHED_HSDESC (with #17242) to indicate when the descriptor has arrived.

Let's find another solution here, like looking at the state. Using purposes here seems very kludgy.

Suggestion from nickm: Can we use the DIR_CONN_STATE_CLIENT_FINISHED state? If the documentation for that state is correct, it should be usable for what we want.

Child Tickets

Change History (11)

comment:1 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

Would require a refactor here so postpone.

comment:2 Changed 2 years ago by dgoulet

Owner: set to dgoulet
Status: newassigned

comment:3 Changed 2 years ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Move 033 ticket I own to 034

comment:4 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 2 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 2 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:7 Changed 12 months ago by gaba

Owner: dgoulet deleted

Releasing some old tickets.

comment:8 Changed 3 months ago by teor

Status: assignednew

Change tickets that are assigned to nobody to "new".

comment:9 Changed 2 weeks ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned

comment:10 Changed 2 weeks ago by neel

Cc: neel removed
Owner: neel deleted

comment:11 Changed 2 weeks ago by neel

Status: assignednew
Note: See TracTickets for help on using tickets.