Opened 14 months ago

Last modified 6 months ago

#23307 assigned defect

hs: Don't bruteforce every pending connection when we get a RENDEZVOUS ack

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #23300 Points:
Reviewer: Sponsor: SponsorR-can

Description

In the v2 subsystem, we have this:

  /* XXXX++ This is a pretty brute-force approach. It'd be better to
   * attach only the connections that are waiting on this circuit, rather
   * than trying to attach them all. See comments bug 743. */
  /* If we already have the introduction circuit built, make sure we send
   * the INTRODUCE cell _now_ */
   connection_ap_attach_pending(1);

And v3 is also doing that (#17242) so we should find another approach to this instead of scanning the entire set of pending connections.

Child Tickets

Change History (6)

comment:1 Changed 13 months ago by dgoulet

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

This might introduce an unstable factor to tor so postponing to 033 as we are trying to stabilize 032.

comment:2 Changed 9 months ago by dgoulet

Owner: set to dgoulet
Status: newassigned

comment:3 Changed 9 months ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Move 033 ticket I own to 034

comment:4 Changed 7 months ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 7 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 6 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.