Opened 4 months ago

Last modified 3 months ago

#23307 new defect

hs: Don't bruteforce every pending connection when we get a RENDEZVOUS ack

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224
Cc: Actual Points:
Parent ID: #23300 Points:
Reviewer: Sponsor: SponsorR-can

Description

In the v2 subsystem, we have this:

  /* XXXX++ This is a pretty brute-force approach. It'd be better to
   * attach only the connections that are waiting on this circuit, rather
   * than trying to attach them all. See comments bug 743. */
  /* If we already have the introduction circuit built, make sure we send
   * the INTRODUCE cell _now_ */
   connection_ap_attach_pending(1);

And v3 is also doing that (#17242) so we should find another approach to this instead of scanning the entire set of pending connections.

Child Tickets

Change History (1)

comment:1 Changed 3 months ago by dgoulet

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

This might introduce an unstable factor to tor so postponing to 033 as we are trying to stabilize 032.

Note: See TracTickets for help on using tickets.