Opened 2 years ago

Closed 2 years ago

#23309 closed defect (fixed)

hs: We need to get rid of a descriptor when entering non-overlap mode

Reported by: dgoulet Owned by: dgoulet
Priority: High Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor: SponsorR-must

Description

From the discussion here: https://oniongit.eu/asn/tor/merge_requests/3#note_905

It seems the solution is to set the next descriptor as the current one when entering the non-overlap mode.

This is v3 service side thus affecting upstream code.

Child Tickets

Change History (9)

comment:1 Changed 2 years ago by asn

Pushed fixes for this in bug23309.

comment:2 Changed 2 years ago by asn

Status: assignedneeds_review

comment:4 Changed 2 years ago by dgoulet

Reviewer: dgoulet
Sponsor: SponsorR-must
Status: needs_reviewneeds_revision

Couple of comments.

comment:5 Changed 2 years ago by dgoulet

Status: needs_revisionmerge_ready

All good with latest fixup. Thanks!

comment:6 Changed 2 years ago by nickm

Could you rebase this onto master and squash it? I tried to do it myself, but it didn't apply cleanly, and I wasn't sure how to fix it up.

comment:7 Changed 2 years ago by asn

No worries! I pushed bug23309_v2 on my tpo repo which is rebased on the latest master!

comment:8 Changed 2 years ago by dgoulet

ack.

comment:9 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Okay, merging

Note: See TracTickets for help on using tickets.