Opened 3 years ago

Closed 3 years ago

#23335 closed defect (fixed)

prop224: Clang compile error + bad log_warn on master

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop224, tor-hs
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: Sponsor: SponsorR-can


Seems like we failed a bit on the latest merges and we introduced a compile error:

In file included from src/or/directory.c:21: 
src/or/directory.h:191: error: redefinition of typedef ‘response_handler_args_t’
src/or/directory.h:181: note: previous declaration of ‘response_handler_args_t’ was here

and also a stray and loud log_warn:

[warn] No change in hsdir set!

We need to fix these!

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by asn

also [warn] Received new dirinfo and set of hsdirs changed!

comment:2 Changed 3 years ago by asn

Pushed branch bug23335 in my repo that should address both issues here.

Roger, can you please test the branch to see that the compilation error is gone with your setup?

comment:3 Changed 3 years ago by asn

Status: newneeds_review

comment:4 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged this; thanks!

Note: See TracTickets for help on using tickets.