Opened 2 years ago

Closed 2 years ago

#23343 closed defect (fixed)

prop224: Bug: Non-fatal assertion !((strlen(req_key_str) + REND_DESC_ID_V2_LEN_BASE32) < strlen(key)) failed

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop224, tor-hs
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: dgoulet Sponsor:

Description

David triggered this in his prop224 testing:

[warn] Bug: Non-fatal assertion !((strlen(req_key_str) + REND_DESC_ID_V2_LEN_BASE32) < strlen(key)) failed in 
                hs_purge_hid_serv_from_last_hid_serv_requests at src/or/hs_common.c:1463. Stack trace: (on Tor 0.3.2.0-alpha-dev f2f1cab2b3c6a56f)

I hanen't managed to repro this yet, but we should fix it anyway.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by asn

Status: newneeds_review

Pushed branch bug23343 that addresses this issue and also adds a unittest to expose it.

Please review this well! :)

comment:2 Changed 2 years ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewneeds_revision

The comment before the condition is wrong I believe.

The key is composed of both the HSDir base32 identity digest and either the base64 blinded key (v3) *OR* the base32 descriptor ID (v2) which is thus the different size explanation.

But yeah BUG() was not a good idea! :P

Apart from that, lgtm;

comment:3 Changed 2 years ago by asn

Pushed fixup that improves comment. Let me know if you like this more.

comment:4 Changed 2 years ago by asn

Status: needs_revisionneeds_review

comment:5 Changed 2 years ago by dgoulet

Status: needs_reviewmerge_ready

ack.

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

okay, merged. :)

Note: See TracTickets for help on using tickets.