Opened 2 years ago

Last modified 18 months ago

#23351 new enhancement

Create a rustfmt.toml defining our whitespace/formatting standards

Reported by: isis Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust rust-pilot style
Cc: manishearth@… Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

We currently have no style consensus for Rust code. It would be good to agree on something! We could agree on whatever the Rust people like (still a WIP last I checked) or we could modify that by creating a `rustfmt.toml`.

We should also probably add a pre-commit hook for running rustfmt, since we have a pretty clean slate and we should keep it clean. :)

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by catalyst

Keywords: style added
Milestone: Tor: unspecified

comment:2 Changed 2 years ago by isis

Priority: MediumLow

comment:3 Changed 2 years ago by manish.earth

Cc: manishearth@… added

comment:4 Changed 2 years ago by frewsxcv

Relevant ticket about adding tooling for Rust linting/formatting: #22156

Also looks like there's already .rustfmt.toml file in src/rust/:

EDIT: Just realized this is a child ticket of #22156 🙈

Last edited 2 years ago by frewsxcv (previous) (diff)

comment:5 Changed 18 months ago by nickm

Parent ID: #22156

unparenting to close parent.

Note: See TracTickets for help on using tickets.